Skip to content

NIFI-5465: Set the Idle Timeout on jetty connectors to the same as th…#2918

Closed
markap14 wants to merge 1 commit intoapache:masterfrom
markap14:NIFI-5465
Closed

NIFI-5465: Set the Idle Timeout on jetty connectors to the same as th…#2918
markap14 wants to merge 1 commit intoapache:masterfrom
markap14:NIFI-5465

Conversation

@markap14
Copy link
Contributor

…e Request Timeout.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@markap14
Copy link
Contributor Author

An easy way to test the PR is to try running the following code (updating the URL in the second line of code to point to a running HandleHttpRequest processor):

public static void main(final String[] args) throws Exception {
        final URL url = new URL("http://localhost:8153/test");
        final URLConnection conn = url.openConnection();

        final HttpURLConnection connection = (HttpURLConnection) conn;
        connection.setRequestMethod("POST");

        connection.setDoOutput(true);
        connection.setFixedLengthStreamingMode(1_000_000);

        connection.connect();

        final OutputStream out = connection.getOutputStream();
        for (int i=0; i < 500_000; i++) {
            out.write('A');
        }

        System.out.println("Sleeping...");
        Thread.sleep(35000);

        for (int i=0; i < 500_000; i++) {
            out.write('A');
        }


        // read the output from the server
        final BufferedReader reader = new BufferedReader(new InputStreamReader(connection.getInputStream()));
        final StringBuilder stringBuilder = new StringBuilder();

        String line = null;
        while ((line = reader.readLine()) != null) {
            stringBuilder.append(line + "\n");
        }

        System.out.println(stringBuilder.toString());
    }

Before the PR, this caused an Exception after sleeping and NiFi did not handle the request. After the PR, NiFI handles it properly and returns the expected response.

@markap14 markap14 closed this Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants