NIFI-5282: GCPProcessor with HTTP Proxy with Authentication#2981
Closed
ijokarumawak wants to merge 2 commits intoapache:masterfrom
Closed
NIFI-5282: GCPProcessor with HTTP Proxy with Authentication#2981ijokarumawak wants to merge 2 commits intoapache:masterfrom
ijokarumawak wants to merge 2 commits intoapache:masterfrom
Conversation
added http proxy support with authentication for GCP processors added proxy support for Google Credential Service This closes apache#2943. Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
Contributor
|
Reviewing... |
Contributor
|
Thanks @ijokarumawak! This has been merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE for reviewer
This PR contains two commits. The 1st one is submitted by @jugi92 via #2943 . I have reviewed the PR and updated few points. Please refer #2943 comments I posted for where I have changed. With those changes, I'd give +1 to #2943, so the 1st comment has 'this closes' comment.
The 2nd commit includes refactoring mentioned above, and also adds ProxyConfiguration support on top of the 1st commit.
Please DO NOT squash these two commits when merging, in order to keep @jugi92 contribution. Thanks!
Some Docker commands to run Squid proxy server
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.