Skip to content

NIFI-5282: GCPProcessor with HTTP Proxy with Authentication#2981

Closed
ijokarumawak wants to merge 2 commits intoapache:masterfrom
ijokarumawak:nifi-5282
Closed

NIFI-5282: GCPProcessor with HTTP Proxy with Authentication#2981
ijokarumawak wants to merge 2 commits intoapache:masterfrom
ijokarumawak:nifi-5282

Conversation

@ijokarumawak
Copy link
Member

NOTE for reviewer

This PR contains two commits. The 1st one is submitted by @jugi92 via #2943 . I have reviewed the PR and updated few points. Please refer #2943 comments I posted for where I have changed. With those changes, I'd give +1 to #2943, so the 1st comment has 'this closes' comment.

The 2nd commit includes refactoring mentioned above, and also adds ProxyConfiguration support on top of the 1st commit.

Please DO NOT squash these two commits when merging, in order to keep @jugi92 contribution. Thanks!

Some Docker commands to run Squid proxy server

# Start a Squid container
docker run -d -p 3128:3128 --name squid salrashid123/squidproxy tail -f /dev/null
# Login to the container
docker exec -it squid bash
# Start proxy without auth
squid/sbin/squid -s -f squid.conf.forward
# or with basic auth
squid/sbin/squid -s -f squid.conf.basicauth
# Stop
squid/sbin/squid -k shutdown

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

jugi92 and others added 2 commits August 31, 2018 20:28
added http proxy support with authentication for GCP processors
added proxy support for Google Credential Service

This closes apache#2943.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
@mcgilman
Copy link
Contributor

Reviewing...

@mcgilman
Copy link
Contributor

Thanks @ijokarumawak! This has been merged to master.

@asfgit asfgit closed this in 5a58c9a Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants