NIFI-5596 Upgraded splunk-sdk-java version#3007
NIFI-5596 Upgraded splunk-sdk-java version#3007mohitgargk wants to merge 1 commit intoapache:masterfrom
Conversation
|
@joewitt I noticed that it adds bouncy castle and jbCrypt. These are transitive depdenencies that come in from security-utils. Should the be added to L&N? |
|
The change itself LGTM, but awaiting L&N feedback. |
MikeThomsen
left a comment
There was a problem hiding this comment.
I think the L&N in the NAR need to be updated. If @joewitt is too busy, I'll try to make the L&N updates based on what I've done before.
|
@MikeThomsen if the nar now includes a dependency it did not previously include then the L&N will need to be updated, if necessary, to reflect that. I dont recall the case of jbcrypt but I dont think that is a new dependency in nifi overall. If we have it in a L or N of a binary artifact elsewhere then we'll want it here too. Make sense? |
|
Yes. Wanted to verify before putting @mohitgargk on a wild goose chase. |
|
@mohitgargk it's mostly copy pasta, so I'll do it. |
|
Merged, thanks for the contribution. @mohitgargk can you manually close this? I got distracted and forgot to add the "closes" line. Thanks. |
|
Thanks @MikeThomsen . |
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.