NIFI-5600 - Restore node location display on queue listing#3021
Closed
pvillard31 wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-5600 - Restore node location display on queue listing#3021pvillard31 wants to merge 1 commit intoapache:masterfrom
pvillard31 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@mcgilman @scottyaslan - friendly ping to be sure I didn't do something against the purpose of NIFI-5208 (#2740) |
Contributor
|
Sorry for missing the mention... Will review |
Contributor
|
@pvillard31 Thanks for the PR! I can see what is happening here and I think a slightly different solution is required. With the introduction of NIFI-5208 we should be watching the cluster status actively so we can track the disconnected state. Because this state can change, I think we need to reconsider the columns we show when the listing is opened (not when the UI is bootstrapped). We actually have the same issue showing component state. I am going to open up another PR with this alternate solution. |
Contributor
|
Provided an alternate solution here: #3055 |
Contributor
Author
|
Thanks much @mcgilman ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.