Skip to content

[NIFI-5795] RedisDistributedMapCacheClientService put missing option#3135

Closed
luup2k wants to merge 1 commit intoapache:masterfrom
luup2k:patch-2
Closed

[NIFI-5795] RedisDistributedMapCacheClientService put missing option#3135
luup2k wants to merge 1 commit intoapache:masterfrom
luup2k:patch-2

Conversation

@luup2k
Copy link
Copy Markdown
Contributor

@luup2k luup2k commented Nov 6, 2018

https://issues.apache.org/jira/browse/NIFI-5795

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Copy Markdown
Contributor

@zenfenan zenfenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing...

@pvillard31
Copy link
Copy Markdown
Contributor

@zenfenan - did you make progress on this one? I see this change has also been added in #3176

@zenfenan
Copy link
Copy Markdown
Contributor

@pvillard31 I wasn't able to. What do you suggest? We'll close this one and cover the objective with #3176 ? or we would merge this in once we verify the changes and ask @javajefe to rebase #3176? The latter feels like a better one.. since this is the first contribution by @luup2k for NiFi

@pvillard31
Copy link
Copy Markdown
Contributor

Agree, I'd prefer to merge this one first, and then take care of the other one.

@pvillard31
Copy link
Copy Markdown
Contributor

Confirmed the reported issue and confirmed the fix. Merging to master, thanks @luup2k

@asfgit asfgit closed this in cc9f89b Dec 3, 2018
javajefe pushed a commit to javajefe/nifi that referenced this pull request Dec 27, 2018
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#3135.

(cherry picked from commit cc9f89b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants