NIFI-5833 Treat GetTwitter API properties as sensitive#3180
NIFI-5833 Treat GetTwitter API properties as sensitive#3180alopresto wants to merge 3 commits intoapache:masterfrom
Conversation
…roperties as sensitive.
…itive values regardless of processor property sensitive status.
…king Consumer Key and Access Token as sensitive.
ijokarumawak
left a comment
ijokarumawak
left a comment
There was a problem hiding this comment.
Posted few minor comments, but other than that, I'm +1. Please fix and merge if there's no other concerns. Thanks!
| @InputRequirement(Requirement.INPUT_FORBIDDEN) | ||
| @Tags({"twitter", "tweets", "social media", "status", "json"}) | ||
| @CapabilityDescription("Pulls status changes from Twitter's streaming API") | ||
| @CapabilityDescription("Pulls status changes from Twitter's streaming API. In versions starting with 1.9.0, the Consumer Key and Access Token are marked as sensitive according to https://developer.twitter.com/en/docs/basics/authentication/guides/securing-keys-and-tokens") |
There was a problem hiding this comment.
I'd move the additional note to each properties as it's not a capability description.
There was a problem hiding this comment.
i think it probably makes sense to leave it here because that link in general is good for users to read and it is more of a higher level concern that the secrets and tokens should be sensitive. Dont have a strong opinion on this but given your +1 koji already i'm going to go ahead and merge this thing as-is after removing the flagged todo.
|
|
||
| // Create a mock Element object to be parsed | ||
|
|
||
| // TODO: Mock call to StandardFlowSynchronizer#readFlowFromDisk() |
There was a problem hiding this comment.
Do we still need this TODO comment?
| </flowController> | ||
| """ | ||
|
|
||
| // TODO: Mock call to StandardFlowSynchronizer#parseFlowBytes() |
There was a problem hiding this comment.
Do we still need this TODO comment?
|
actually looks like the todo may be legit to hang around in general and isn't specific to this twitter scenario so will leave that alone. given kojis review and comments and mine am +1 will merge to master |
3 participants
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.