Skip to content

NIFI-5908 Inject locale info into JsonInjector object to make sure we…#3226

Closed
MikeThomsen wants to merge 1 commit intoapache:masterfrom
MikeThomsen:NIFI-5908
Closed

NIFI-5908 Inject locale info into JsonInjector object to make sure we…#3226
MikeThomsen wants to merge 1 commit intoapache:masterfrom
MikeThomsen:NIFI-5908

Conversation

@MikeThomsen
Copy link
Contributor

… don't lose that information.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@MikeThomsen
Copy link
Contributor Author

MikeThomsen commented Dec 18, 2018

@markap14 @pvillard31 can one of you review since this aims to correct a regression that appears to have been introduced w/ NIFI-5814?

@MikeThomsen
Copy link
Contributor Author

DB direct download here

@pvillard31
Copy link
Contributor

I'm a +1, giving a chance to @markap14 to also have a look, otherwise will merge later

@MikeThomsen
Copy link
Contributor Author

@pvillard31 @markap14 @trixpan how did y'all test the ISPEnrich processor? Did someone buy access to the maxmind database for that data? Asking because I just did GeoEnrichIPRecord and am thinking about doing a record enrichment option for ISP data.

@pvillard31
Copy link
Contributor

Merged to master, thanks @MikeThomsen

@asfgit asfgit closed this in 6fa5dea Jan 3, 2019
@MikeThomsen MikeThomsen deleted the NIFI-5908 branch August 14, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants