NIFI-5897 Update GetFile and ListFile Min Age to handle future dated …

[patricker]

…files

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced
  in the commit message?

• Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• Has your PR been rebased against the latest commit within the target branch (typically master)?

• Is your initial contribution a single, squashed commit?

For code changes:

• Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
• Have you written or updated unit tests to verify your changes?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
• If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
• If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

[ijokarumawak]

@patricker Thanks for the fix. The change looks good, but Travis reported some test failures. Would you check if the added tests have any environmental dependent assumption?

[ERROR] Failures: 
[ERROR]   TestGetFile.testMinAgeFilesPickedUp:237 expected:<1> but was:<0>
[ERROR]   TestGetFile.testMinAgeWithFutureDateFiles:265 expected:<1> but was:<0>
[INFO] 
[ERROR] Tests run: 1466, Failures: 2, Errors: 0, Skipped: 23

https://api.travis-ci.org/v3/job/470167873/log.txt

[MikeThomsen]

@patricker for some reason, the unit tests won't complete for me with the time ~ line 265 set to 1 sec. If I run that one test manually, it works as-is, but it won't work if they're run together. I set it to 100ms, and everything completed fine. If that works for you, I'm good with the change and ready to approve.

[MikeThomsen]

@patricker can you respond to my review question above?

[patricker]

@MikeThomsen Thanks for the reminder.
I felt that changing it to 100ms was just waiting for some faster machine to run into this race condition. I set it to 100ms, but also added a 200ms thread sleep, so no matter how fast this test runs it should always succeed.

[github-actions]

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.