Skip to content

Conversation

@MikeThomsen
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@MikeThomsen
Copy link
Contributor Author

@markap14 @pvillard31 could one of your review?

@MikeThomsen
Copy link
Contributor Author

@pvillard31 @mattyb149 @zenfenan any chance of a review?

@MikeThomsen
Copy link
Contributor Author

@pvillard31 @bbende could one of you review? FWIW, we're actually using this processor at my client site to enrich very large CSV data sets.

Copy link
Contributor

@mattyb149 mattyb149 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some functionality provided by this that isn't available in IPLookupService? I thought you could use either the commercial or free Maxmind DB for either? If not, would it be better to augment the current one? If a new processor is necessary that's fine, just want to make sure we don't have too many equivalent ways of doing things.

@MikeThomsen
Copy link
Contributor Author

@mattyb149 thanks, I'll try to get to these tonight!

NIFI-5902 Updated GeoEnrichIPRecord with more error handling.
@MikeThomsen
Copy link
Contributor Author

Done.

@MikeThomsen
Copy link
Contributor Author

@mattyb149 I think we're ready to merge now.

@MikeThomsen
Copy link
Contributor Author

Thanks @mattyb149 I'll try to get these done soon.

@MikeThomsen
Copy link
Contributor Author

Changes pushed @mattyb149

@MikeThomsen
Copy link
Contributor Author

@mattyb149 made the change

@mattyb149
Copy link
Contributor

+1 LGTM, ran unit tests and tried various paths on a live NiFi instance, behavior is as expected and described. Thanks Mike for sticking with this! Merging to master

@asfgit asfgit closed this in 3e7816d Jun 12, 2019
@MikeThomsen
Copy link
Contributor Author

Thanks! I'd like to do the ISP one as well, but I'm going to have to find someone willing to buy me the database ;)

@MikeThomsen MikeThomsen deleted the NIFI-5902 branch August 14, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants