Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-5927 Added SECURITY.md to project root. #3243

Closed
wants to merge 1 commit into from

Conversation

@alopresto
Copy link
Contributor

alopresto commented Jan 4, 2019

Removed reference to Jasypt from cryptography section of README.md.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Removed reference to Jasypt from cryptography section of README.md.
@andrewmlim

This comment has been minimized.

Copy link
Contributor

andrewmlim commented Jan 4, 2019

Reviewing.

of sensitive configuration parameters. See
http://bouncycastle.org/about.html
http://www.jasypt.org/faq.html
http://jcraft.com/c-info.html

This comment has been minimized.

Copy link
@andrewmlim

andrewmlim Jan 4, 2019

Contributor

I noticed that this jcraft link doesn't work in Chrome (Version 71.0.3578.98), but does for Safari and FireFox. Chrome requires:

http://www.jcraft.com/c-info.html

@andrewmlim

This comment has been minimized.

Copy link
Contributor

andrewmlim commented Jan 4, 2019

Besides updating the jcraft link, everything else LGTM. Thanks @alopresto!

@alopresto alopresto closed this in c206c0f Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.