Skip to content

NIFI-5928 Use NiFiDataPacket in the Flink source#3244

Closed
ambition119 wants to merge 4 commits intoapache:masterfrom
ambition119:master
Closed

NIFI-5928 Use NiFiDataPacket in the Flink source#3244
ambition119 wants to merge 4 commits intoapache:masterfrom
ambition119:master

Conversation

@ambition119
Copy link

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • [ ✅] Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • [✅ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • [ ✅] Has your PR been rebased against the latest commit within the target branch (typically master)?

  • [ ✅] Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@ambition119
Copy link
Author

@rwhittington @pvillard31 Could you help review this PR?

@ambition119 ambition119 changed the title NIFI-5928 Use NiFiDataPacket in the Flinksource NIFI-5928 Use NiFiDataPacket in the Flink source Jan 4, 2019
@bbende
Copy link
Contributor

bbende commented Jan 7, 2019

@ambition119 currently the flink nifi connectors are part of flink, so shouldn't this PR be against the flink repo?

https://github.com/apache/flink/tree/master/flink-connectors/flink-connector-nifi

@ambition119
Copy link
Author

@ambition119 currently the flink nifi connectors are part of flink, so shouldn't this PR be against the flink repo?

https://github.com/apache/flink/tree/master/flink-connectors/flink-connector-nifi

ok

@ambition119 ambition119 closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants