NIFI-5937 use processor-configured encoding instead of the system default#3250
NIFI-5937 use processor-configured encoding instead of the system default#3250SavtechSolutions wants to merge 4 commits intoapache:masterfrom
Conversation
|
Reviewing |
|
added some unit tests (copied them from my other PR that got stuck in review for whatever reason) |
bdesert
left a comment
There was a problem hiding this comment.
Checkstyle is failing:
[WARNING] src/test/java/org/apache/nifi/processors/elasticsearch/TestPutElasticsearchHttpRecord.java:[20] (imports) AvoidStarImport: Using the '.' form of import should be avoided - okhttp3..
[WARNING] src/test/java/org/apache/nifi/processors/elasticsearch/TestPutElasticsearchHttpRecord.java:[43] (imports) AvoidStarImport: Using the '.' form of import should be avoided - org.junit.Assert..
I would recommend to run
mvn -T 2 clean install -Pcontrib-check -Ddir-only
on the projects that have been changed.
|
+1 LGTM. Ran unit tests and with elastic-mock. works as expected.Thanks for the improvement! Merged to master |
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.