Skip to content

NIFI-5949: Addressed problematic error handling logic in PutKudu. Als…#3262

Closed
markap14 wants to merge 1 commit intoapache:masterfrom
markap14:NIFI-5949
Closed

NIFI-5949: Addressed problematic error handling logic in PutKudu. Als…#3262
markap14 wants to merge 1 commit intoapache:masterfrom
markap14:NIFI-5949

Conversation

@markap14
Copy link
Copy Markdown
Contributor

…o removed AbstractKudu and moved all logic into PutKudu, as the abstract class was clearly designed to be extended only by PutKudu and no other processors exist for Kudu

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

…o removed AbstractKudu and moved all logic into PutKudu, as the abstract class was clearly designed to be extended only by PutKudu and no other processors exist for Kudu
@markap14
Copy link
Copy Markdown
Contributor Author

@jtstorck any chance you can take a look at this and make sure that I didn't break anything? :)

@jtstorck
Copy link
Copy Markdown
Contributor

Reviewing...

@jtstorck jtstorck closed this in fd3d69b Jan 25, 2019
@jtstorck
Copy link
Copy Markdown
Contributor

Tested the PutKudu changes, looking good. Needed to add an explicit .toString() call on rowErrors to avoid an issue with an IllegalStateException getting thrown when iterating through rowErrors to log them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants