NIFI-5952 Refactor RAW S2S from nio to socket#3265
Closed
ijokarumawak wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-5952 Refactor RAW S2S from nio to socket#3265ijokarumawak wants to merge 1 commit intoapache:masterfrom
ijokarumawak wants to merge 1 commit intoapache:masterfrom
Conversation
cf85d34 to
529dab3
Compare
11 tasks
529dab3 to
9932f06
Compare
9932f06 to
5203b86
Compare
Contributor
|
Thanks for the update @ijokarumawak . I don't love that we are going from NIO to the "regular IO" based API, but I agree with your assessment that it's a fairly straight-forward change that will allow us to use site-to-site with Java 11. I did test this against both Java 8 and Java 11 and things seemed to be working well. +1 Have merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE This PR is based on NIFI-5820's PR branch because this fix is required after NIFI-5820 is merged, in order to support Site-to-Site with RAW transport protocol running on Java 11.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.