Skip to content

NIFI-5952 Refactor RAW S2S from nio to socket#3265

Closed
ijokarumawak wants to merge 1 commit intoapache:masterfrom
ijokarumawak:nifi-5952
Closed

NIFI-5952 Refactor RAW S2S from nio to socket#3265
ijokarumawak wants to merge 1 commit intoapache:masterfrom
ijokarumawak:nifi-5952

Conversation

@ijokarumawak
Copy link
Member

NOTE This PR is based on NIFI-5820's PR branch because this fix is required after NIFI-5820 is merged, in order to support Site-to-Site with RAW transport protocol running on Java 11.


Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@ijokarumawak ijokarumawak changed the title NIFI-5174 Refactor RAW S2S from nio to socket NIFI-5952 Refactor RAW S2S from nio to socket Jan 11, 2019
@markap14
Copy link
Contributor

Thanks for the update @ijokarumawak . I don't love that we are going from NIO to the "regular IO" based API, but I agree with your assessment that it's a fairly straight-forward change that will allow us to use site-to-site with Java 11. I did test this against both Java 8 and Java 11 and things seemed to be working well. +1 Have merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants