Skip to content

NIFI-5967: Add Hive 1.1 processors#3272

Closed
mattyb149 wants to merge 2 commits intoapache:masterfrom
mattyb149:NIFI-5967
Closed

NIFI-5967: Add Hive 1.1 processors#3272
mattyb149 wants to merge 2 commits intoapache:masterfrom
mattyb149:NIFI-5967

Conversation

@mattyb149
Copy link
Copy Markdown
Contributor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@jtstorck
Copy link
Copy Markdown
Contributor

jtstorck commented Feb 4, 2019

Reviewing...

@jtstorck
Copy link
Copy Markdown
Contributor

jtstorck commented Feb 7, 2019

Functionality looks good, so I'm ready to merge this PR after the NOTICE update has been made.

…ive NARs, removed unnecessary NOTICE entries
@jtstorck
Copy link
Copy Markdown
Contributor

jtstorck commented Feb 8, 2019

Thanks, @mattyb149! Reviewed and tested your changes after your last commit. Looks good! I updated the Hive_1_1ConnectionPoolTest.testKerberosAuthException test to use a mocked KerberosCredentialsService.

+1, merged to master!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants