NIFI-1690 Changed MonitorMemory to use allowable values for pool names#328
Closed
olegz wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-1690 Changed MonitorMemory to use allowable values for pool names#328olegz wants to merge 1 commit intoapache:masterfrom
olegz wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
olegz
commented
Apr 5, 2016
olegz
commented
- removed dead code from MonitorMemory
- added MonitorMemoryTest
- minor refactoring in MonitorMemory
- initial fix for NIFI-1731 (WARN/INFO logging) that was required by MonitorMemoryTest
olegz
force-pushed
the
NIFI-1690
branch
5 times, most recently
from
d8f7efd to
a4bcaeb
Compare
| .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) | ||
| .defaultValue(null) | ||
| .allowableValues(memPoolAllowableValues) | ||
| .defaultValue(memPoolAllowableValues.length == 0 ? null : memPoolAllowableValues[0].getValue()) |
Contributor
There was a problem hiding this comment.
I think we're better off simply not having a default value.
Contributor
Author
|
@alopresto all is addressed. Let me know. |
Contributor
|
Thanks @olegz . If you rebase and squash, I'll verify and merge. |
Contributor
Author
|
@alopresto all done |
Contributor
|
I've tried to build this locally twice (clean checkouts and everything). It is failing with a compilation error in The compilation error is below: Any thoughts? |
- removed dead code from MonitorMemory - added MonitorMemoryTest - minor refactoring in MonitorMemory - initial fix for NIFI-1731 (WARN/INFO logging) that was required by MonitorMemoryTest NIFI-1690 polishing NIFI-1690 address PR comments, removed default value for MEMORY_POOL_PROPERTY NIFI-1690 addressed latest PR comments NIFI-1690 fixed breaking changes
Contributor
Author
|
@alopresto just fixed it. Took me a while to figure out what's going on but you can read some details here: https://issues.apache.org/jira/browse/NIFI-1730 (last comment). Also, I am now going to have to make a separate PR for 0.x. Arghhhhhhh |
Contributor
|
Merged and closed. Will do the same for PR 533. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.