Skip to content

NIFI-5988 Fixed validation issues on database and collection names.#3286

Closed
MikeThomsen wants to merge 3 commits intoapache:mainfrom
MikeThomsen:NIFI-5988
Closed

NIFI-5988 Fixed validation issues on database and collection names.#3286
MikeThomsen wants to merge 3 commits intoapache:mainfrom
MikeThomsen:NIFI-5988

Conversation

@MikeThomsen
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@MikeThomsen
Copy link
Contributor Author

@zenfenan @mattyb149

Copy link
Contributor

@zenfenan zenfenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing.

Copy link
Contributor

@zenfenan zenfenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made one suggestion for the database name validator. Other than that, everything looks good to me.

@MikeThomsen
Copy link
Contributor Author

@zenfenan made the change.

@MikeThomsen
Copy link
Contributor Author

@zenfenan @mattyb149 can we close this?

@MikeThomsen
Copy link
Contributor Author

@zenfenan @mattyb149 can we close this out?

@MikeThomsen MikeThomsen changed the base branch from master to main July 7, 2020 19:09
@github-actions
Copy link

github-actions bot commented May 2, 2021

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

@github-actions github-actions bot added the Stale label May 2, 2021
@github-actions github-actions bot closed this May 18, 2021
@MikeThomsen MikeThomsen deleted the NIFI-5988 branch August 14, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants