Skip to content

NIFI-5916 Added an option to enable empty flowfiles to be sent if the…#3315

Closed
MikeThomsen wants to merge 2 commits intoapache:masterfrom
MikeThomsen:NIFI-5916
Closed

NIFI-5916 Added an option to enable empty flowfiles to be sent if the…#3315
MikeThomsen wants to merge 2 commits intoapache:masterfrom
MikeThomsen:NIFI-5916

Conversation

@MikeThomsen
Copy link
Contributor

…re are no results from a query.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@mattyb149
Copy link
Contributor

Lookin pretty good, left one comment, also please rebase while incorporating any changes, thanks!

@MikeThomsen
Copy link
Contributor Author

@mattyb149 we're ready to merge.

@mattyb149
Copy link
Contributor

+1 LGTM, ran unit and integration tests, and tested with a live NiFi instance, both with and without incoming flow files and with "output empty" set to both true and false. Thanks for the improvement! Merging to master

@asfgit asfgit closed this in 407add7 Jun 1, 2019
@Damien60
Copy link

Hello,
This behavior (NIFI-5916) was not extended to FetchGridFS. Is it possible to add it?
Thanks.

@mattyb149
Copy link
Contributor

@Damien60 yes, please feel free to write up a Jira case to add this feature to FetchGridFS

@MikeThomsen MikeThomsen deleted the NIFI-5916 branch August 14, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants