Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-6106 Add tests for commons utilities & fix FormatUtils bug #3354

Closed

Conversation

@freddytuxworth
Copy link
Contributor

commented Mar 6, 2019

I analyzed this project and noticed some methods lacking tests in these two utilities classes. I've written some tests using Diffblue Cover which should hopefully help you to detect any regressions caused by future code changes.

I also corrected a small bug in FormatUtils which caused the formatNanos method to incorrectly format multiples of 1000000 or 1000000000 to "0 nanos".

Please let me know if there are any other areas of your project which you would like tests written for, I would be more than happy to help.

freddytuxworth added some commits Mar 6, 2019

Added tests for commons utilities StringUtils and FormatUtils
These tests were written using Diffblue Cover.
@mattyb149

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

+1 LGTM, Travis is happy so I'm happy :) Thanks for the nanos fix and the extra tests! Merging to master

@asfgit asfgit closed this in 08a307c Mar 6, 2019

rwithers added a commit to rwithers/nifi that referenced this pull request May 3, 2019

Added tests for commons utilities StringUtils and FormatUtils
These tests were written using Diffblue Cover.

Fixed bug in FormatUtils.formatNanos

Fix import asterisk warning

Add Apache license header.

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes apache#3354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.