NIFI-6106 Add tests for commons utilities & fix FormatUtils bug#3354
Closed
freddytuxworth wants to merge 4 commits intoapache:masterfrom
Closed
NIFI-6106 Add tests for commons utilities & fix FormatUtils bug#3354freddytuxworth wants to merge 4 commits intoapache:masterfrom
freddytuxworth wants to merge 4 commits intoapache:masterfrom
Conversation
added 3 commits
March 6, 2019 12:27
These tests were written using Diffblue Cover.
mattyb149
reviewed
Mar 6, 2019
nifi-commons/nifi-properties/src/test/java/org/apache/nifi/util/StringUtilsTest.java
Outdated
Show resolved
Hide resolved
mattyb149
reviewed
Mar 6, 2019
nifi-commons/nifi-properties/src/test/java/org/apache/nifi/util/StringUtilsTest.java
Show resolved
Hide resolved
Contributor
|
+1 LGTM, Travis is happy so I'm happy :) Thanks for the nanos fix and the extra tests! Merging to master |
rwithers
pushed a commit
to rwithers/nifi
that referenced
this pull request
May 3, 2019
These tests were written using Diffblue Cover. Fixed bug in FormatUtils.formatNanos Fix import asterisk warning Add Apache license header. Signed-off-by: Matthew Burgess <mattyb149@apache.org> This closes apache#3354
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I analyzed this project and noticed some methods lacking tests in these two utilities classes. I've written some tests using Diffblue Cover which should hopefully help you to detect any regressions caused by future code changes.
I also corrected a small bug in
FormatUtilswhich caused theformatNanosmethod to incorrectly format multiples of 1000000 or 1000000000 to"0 nanos".Please let me know if there are any other areas of your project which you would like tests written for, I would be more than happy to help.