Skip to content

NIFI-6108: Fix port names when imported from registry#3356

Closed
kevdoran wants to merge 1 commit intoapache:masterfrom
kevdoran:NIFI-6108-imported-port-names
Closed

NIFI-6108: Fix port names when imported from registry#3356
kevdoran wants to merge 1 commit intoapache:masterfrom
kevdoran:NIFI-6108-imported-port-names

Conversation

@kevdoran
Copy link
Copy Markdown
Contributor

@kevdoran kevdoran commented Mar 6, 2019

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@bbende
Copy link
Copy Markdown
Contributor

bbende commented Mar 6, 2019

Reviewing...

@kevdoran kevdoran force-pushed the NIFI-6108-imported-port-names branch from f233a89 to c4a145a Compare March 6, 2019 21:45
@kevdoran kevdoran marked this pull request as ready for review March 6, 2019 21:53
@bbende
Copy link
Copy Markdown
Contributor

bbende commented Mar 6, 2019

Looks good, verified functionality, going to merge

@asfgit asfgit closed this in 1d06044 Mar 6, 2019
asfgit pushed a commit that referenced this pull request Mar 12, 2019
This closes #3356.

Signed-off-by: Bryan Bende <bbende@apache.org>
rwithers pushed a commit to rwithers/nifi that referenced this pull request May 3, 2019
This closes apache#3356.

Signed-off-by: Bryan Bende <bbende@apache.org>
szaboferee pushed a commit to szaboferee/nifi that referenced this pull request Aug 15, 2019
This closes apache#3356.

Signed-off-by: Bryan Bende <bbende@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants