Skip to content

NIFI-6184: Removed unnecessary test-jar dep from nifi-livy-processors…#3413

Closed
mattyb149 wants to merge 1 commit intoapache:masterfrom
mattyb149:NIFI-6184
Closed

NIFI-6184: Removed unnecessary test-jar dep from nifi-livy-processors…#3413
mattyb149 wants to merge 1 commit intoapache:masterfrom
mattyb149:NIFI-6184

Conversation

@mattyb149
Copy link
Contributor

… causing race condition, added assertion to catch failures

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

… causing race condition, added assertion to catch failures
@mattyb149
Copy link
Contributor Author

There seems to be a race condition between the publishing of the nifi-standard-processors test-jar artifact, and the resolution by the nifi-livy-processors module. These events seem (at least lately) to be occurring in parallel, causing most/all Travis CI builds to timeout. Note that the same race condition could happen with any other parallel goal execution, if the other module's goal includes resolving the nifi-standard-processors test-jar dependency. We may want to update the POM and/or .travis.yml to ensure that artifact is published before other NAR modules are built, but in the meantime, this PR seems to stabilize the build.

@asfgit asfgit closed this in 8572852 Apr 8, 2019
lfrancke pushed a commit to lfrancke/nifi that referenced this pull request Apr 9, 2019
…from nifi-livy-processors causing race condition, added assertion to catch failures

Signed-off-by: Joe Witt <joewitt@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant