Skip to content

NIFI-6096: Fixed ValidateRecord handling of nested maps#3424

Closed
mattyb149 wants to merge 1 commit intoapache:masterfrom
mattyb149:NIFI-6096
Closed

NIFI-6096: Fixed ValidateRecord handling of nested maps#3424
mattyb149 wants to merge 1 commit intoapache:masterfrom
mattyb149:NIFI-6096

Conversation

@mattyb149
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


public static boolean isMapTypeCompatible(final Object value) {
return value != null && value instanceof Map;
return value != null && (value instanceof Map || value instanceof MapRecord);
Copy link
Contributor Author

@mattyb149 mattyb149 Apr 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a little hacky to me, but the alternative was to refactor a bunch of code that validates record fields, so we could instead validate map entries. It would also entail changing the JSON Reader(s) (at the least) to generate Maps instead of MapRecords as it does now. So I'm checking specifically for MapRecord (not Record) to say that it's compatible with a MAP type, which is consistent with the example schema and data (a MapRecord is created but the type is MAP<STRING>).

Copy link
Contributor

@MikeThomsen MikeThomsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM and ran successfully against @JPercivall's example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants