Skip to content

NIFI-6304 added trim, toLowerCase and toUpperCase to record path oper…#3478

Closed
MikeThomsen wants to merge 6 commits intoapache:masterfrom
MikeThomsen:NIFI-6304
Closed

NIFI-6304 added trim, toLowerCase and toUpperCase to record path oper…#3478
MikeThomsen wants to merge 6 commits intoapache:masterfrom
MikeThomsen:NIFI-6304

Conversation

@MikeThomsen
Copy link
Contributor

…ations.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Member

@ijokarumawak ijokarumawak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements @MikeThomsen !
I think we should separate Concat and these added functions. Please see my comments for detail.

@ijokarumawak
Copy link
Member

ijokarumawak commented May 22, 2019

Moved this comment to here

@MikeThomsen
Copy link
Contributor Author

@ijokarumawak I think all of your concerns have been addressed now.

Copy link
Member

@ijokarumawak ijokarumawak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MikeThomsen for the updates and documentation!
I still think these functions should convert multiple FieldValues as multiple FieldValues. Applying function to each fields passed through the stream. To explain what exact I'm imagining, I've submitted a PR to your branch. Please take a look. MikeThomsen#3 (Also, the PR addresses all of following comments)

@MikeThomsen
Copy link
Contributor Author

@ijokarumawak merged your changes and reverted Concat.java.

@ijokarumawak
Copy link
Member

@MikeThomsen LGTM +1. Thanks for the updates, all work as expected including combined functions such as trim(toUpperCase(/name)). Merging to master!

@asfgit asfgit closed this in 6a06cd3 May 28, 2019
@MikeThomsen MikeThomsen deleted the NIFI-6304 branch August 14, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants