Skip to content

NIFI-6244: Revert "Provide default ORDER BY clause in MSSQL adapters"#3512

Closed
mattyb149 wants to merge 1 commit intoapache:masterfrom
mattyb149:NIFI-6244_revert
Closed

NIFI-6244: Revert "Provide default ORDER BY clause in MSSQL adapters"#3512
mattyb149 wants to merge 1 commit intoapache:masterfrom
mattyb149:NIFI-6244_revert

Conversation

@mattyb149
Copy link
Contributor

This reverts commit 7fc49c2. The solution only fixes the issue that the parser won't allow paging without an ORDER BY clause, it doesn't provide a correct default ordering, and thus the results are unpredictable.

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@mcgilman
Copy link
Contributor

mcgilman commented Jun 4, 2019

Thanks @mattyb149. This has been merged to master.

@asfgit asfgit closed this in 08d2e69 Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants