NIFI-6349 Fix to MergeRecords for fragments over multiple iterations#3517
Conversation
ijokarumawak
reviewed
Jun 7, 2019
Member
ijokarumawak
left a comment
ijokarumawak
left a comment
There was a problem hiding this comment.
@Evanthx thanks for reporting the issue with a reproducible template and a fix! I was able to confirm this PR addresses the issue. I just wanted to make sure one trivial thing before merging this. Please check my comment. Thanks!
...ard-processors/src/main/java/org/apache/nifi/processors/standard/merge/RecordBinManager.java
Outdated
Show resolved
Hide resolved
Member
|
All LGTM +1, merging to master. Thanks @Evanthx for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When MergeRecords tries to merge fragments it will close the bin after a single run. This means that fragments that come in seconds apart will not be merged but will fail.
The ticket (https://issues.apache.org/jira/browse/NIFI-6349) contains reproduction steps.