Skip to content

NIFI-6405 GetHDFSFileInfo ignores files in the root/start directory#3558

Closed
szaboferee wants to merge 1 commit intoapache:masterfrom
szaboferee:NIFI-6405
Closed

NIFI-6405 GetHDFSFileInfo ignores files in the root/start directory#3558
szaboferee wants to merge 1 commit intoapache:masterfrom
szaboferee:NIFI-6405

Conversation

@szaboferee
Copy link
Contributor

@szaboferee szaboferee commented Jun 28, 2019

modifying test cases, fixing file processing.

Testing done:

  • Unit tests
  • Manual run against a hadoop instance

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

modifying test cases, fixing file processing.

Testing done:
- Unit tests
- Manual run against a hadoop instance
@jtstorck
Copy link
Contributor

Reviewing...

@jtstorck
Copy link
Contributor

Initial tests run with the PR changes look good. I will do a bit more review, and then most likely merge these changes tomorrow.

@jtstorck jtstorck closed this in 3d21059 Jul 1, 2019
@jtstorck
Copy link
Contributor

jtstorck commented Jul 1, 2019

+1, LGTM
Thanks for the contribution, @szaboferee! Merged to master.

szaboferee added a commit to szaboferee/nifi that referenced this pull request Oct 7, 2019
modifying test cases, fixing file processing.

Testing done:
- Unit tests
- Manual run against a hadoop instance

This closes apache#3558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants