Skip to content

NIFI-6433 Update getStatusHistory to honor filter values.#3579

Closed
jmark99 wants to merge 1 commit intoapache:masterfrom
jmark99:NIFI-6433
Closed

NIFI-6433 Update getStatusHistory to honor filter values.#3579
jmark99 wants to merge 1 commit intoapache:masterfrom
jmark99:NIFI-6433

Conversation

@jmark99
Copy link
Contributor

@jmark99 jmark99 commented Jul 11, 2019

This modification updates the getStatusHistory method of
VolatileComponentStatusRepository to utilize the start, end, and
preferredDataPoints parameters when retrieving status histories.

When calling the various getStatusHistory methods of
VolatileComponentStatusRepository, they are all passed start, end,
and preferredDataPoints values to allow the filtering of histories
according to the provided parameters. But the follow-on method calls ignore
those values completely. This ticket updates those methods to honor the
parameters and filter the returned Dates accordingly.

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • [x ] Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • [x ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • [ x] Has your PR been rebased against the latest commit within the target branch (typically master)?

  • [x ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • [x ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • [ x] Have you written or updated unit tests to verify your changes?
  • [x ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [ x] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • [ x] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • [ x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • [ x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

This modification updates the getStatusHistory method of
VolatileComponentStatusRepository to utilize the start, end, and
preferredDataPoints parameters when retrieving status histories.

When calling the various get<XXXX>StatusHistory methods of
VolatileComponentStatusRepository, they are all passed start, end,
and preferredDataPoints values to allow the filtering of histories
according to the provided parameters. But the follow-on method calls ignore
those values completely. This ticket updates those methods to honor the
parameters and filter the returned Dates accordingly.
@asfgit asfgit closed this in d1c30d1 Jul 26, 2019
@jmark99 jmark99 deleted the NIFI-6433 branch October 2, 2019 13:10
szaboferee pushed a commit to szaboferee/nifi that referenced this pull request Oct 7, 2019
This modification updates the getStatusHistory method of
VolatileComponentStatusRepository to utilize the start, end, and
preferredDataPoints parameters when retrieving status histories.

When calling the various get<XXXX>StatusHistory methods of
VolatileComponentStatusRepository, they are all passed start, end,
and preferredDataPoints values to allow the filtering of histories
according to the provided parameters. But the follow-on method calls ignore
those values completely. This ticket updates those methods to honor the
parameters and filter the returned Dates accordingly.

This closes apache#3579.

Signed-off-by: Mark Payne <markap14@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant