Skip to content

NIFI-6511:Resolve the problem:select processor data provenance null,must restar…#3619

Closed
H3CDataEngine wants to merge 1 commit intoapache:masterfrom
H3CDataEngine:NIFI-6511
Closed

NIFI-6511:Resolve the problem:select processor data provenance null,must restar…#3619
H3CDataEngine wants to merge 1 commit intoapache:masterfrom
H3CDataEngine:NIFI-6511

Conversation

@H3CDataEngine
Copy link
Copy Markdown

…t nifi can select data provenance.

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

The problem: when flowfile is not generated for a long time,when the time over nifi.provenance.repository.max.storage.time ,the provenacne_repository/*.prov file will be delete.
And it does not satisfy the roll condition,so wo select data provenance failed.

The resolve method:I add condition to judge tryClaim() and add condition to judge shouldRoll(),so when *.prov is delete,and new data provenance is generated ,new prov file generate and can be successful to select data provenance.

Enables X functionality; fixes bug NIFI-6511.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@markap14
Copy link
Copy Markdown
Contributor

@H3CDataEngine thanks for the contribution! Can you indicate which Jira this pertains to, though? The comment indicates NIFI-6511, but that appears to be a typo. NIFI-6511 has to do with "Predictive Analytics for NiFi Metrics"

@H3CDataEngine
Copy link
Copy Markdown
Author

NIFI-6511:Resolve the problem:select processor data provenance null,must restart

@github-actions
Copy link
Copy Markdown

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

@github-actions github-actions bot added the Stale label Apr 25, 2021
@github-actions github-actions bot closed this May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants