Skip to content

NIFI-6525 - Support JsonPath delete expressions#3632

Closed
mans2singh wants to merge 3 commits intoapache:masterfrom
mans2singh:NIFI-6525
Closed

NIFI-6525 - Support JsonPath delete expressions#3632
mans2singh wants to merge 3 commits intoapache:masterfrom
mans2singh:NIFI-6525

Conversation

@mans2singh
Copy link
Copy Markdown
Contributor

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Support JsonPath delete expressions

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@pvillard31
Copy link
Copy Markdown
Contributor

Hey @mans2singh - can you rebase your PR against master?

@mans2singh
Copy link
Copy Markdown
Contributor Author

@pvillard31 -

I've rebased to master and updated the code. Please let me know if you have any additional advice.

Thanks

Copy link
Copy Markdown
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change to do, otherwise I made somes tests and it LGTM. I'm +1 once the comment is addressed.

@pvillard31
Copy link
Copy Markdown
Contributor

Merged to master, thanks @mans2singh

@asfgit asfgit closed this in 2491c51 Aug 7, 2019
@mans2singh
Copy link
Copy Markdown
Contributor Author

Thanks @pvillard31 for your all your help.

tpalfy pushed a commit to tpalfy/nifi that referenced this pull request Aug 12, 2019
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#3632.
tpalfy pushed a commit to tpalfy/nifi that referenced this pull request Aug 21, 2019
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#3632.
szaboferee pushed a commit to szaboferee/nifi that referenced this pull request Oct 7, 2019
Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#3632.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants