Skip to content

NIFI-4542, add target.dir.created to indicate if the target directory created#3641

Closed
avseq1234 wants to merge 7 commits intoapache:mainfrom
avseq1234:NIFI-4542
Closed

NIFI-4542, add target.dir.created to indicate if the target directory created#3641
avseq1234 wants to merge 7 commits intoapache:mainfrom
avseq1234:NIFI-4542

Conversation

@avseq1234
Copy link
Contributor

@avseq1234 avseq1234 commented Aug 9, 2019

… created

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Add target.dir.created attribute to output flowfile to indicate if the target directory created.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

avseq1234 and others added 3 commits August 9, 2019 19:50
…der response when the OIDC Identifying User claim is not found. Revised log message to print available claims.

Added new StandardOidcIdentityProviderGroovyTest file.
Updated deprecated methods in StandardOidcIdentityProvider. Changed log output to print all available claim names from JWTClaimsSet. Added unit test.
Added comments in getAvailableClaims() method.
Fixed typos in NiFi Docs Admin Guide.
Added license to Groovy test.
Fixed a checkstyle error.
Refactor exchangeAuthorizationCode method.
Added unit tests.
Verified all unit tests added so far are passing.
Refactored code. Added unit tests.
Refactored OIDC provider to decouple constructor & network-dependent initialization.
Added unit tests.
Added unit tests.
Refactored OIDC provider to separately authorize the client. Added unit tests.
Added unit tests.

NIFI-7332 Refactored exchangeAuthorizationCode method to separately retrieve the NiFi JWT.

Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes apache#4344.
@github-actions
Copy link

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

@github-actions github-actions bot added the Stale label Apr 25, 2021
@avseq1234
Copy link
Contributor Author

can we re-open this issue?

@github-actions github-actions bot removed the Stale label Apr 26, 2021
@github-actions
Copy link

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

@github-actions github-actions bot added the Stale label Aug 25, 2021
@github-actions github-actions bot closed this Sep 9, 2021
@pvillard31 pvillard31 reopened this Sep 9, 2021
@pvillard31 pvillard31 changed the base branch from master to main September 9, 2021 07:34
@pvillard31
Copy link
Contributor

@avseq1234 - it sounds like a straightforward change, can you rebase against main and fix conflicts?

@pvillard31 pvillard31 removed the Stale label Sep 9, 2021
@avseq1234
Copy link
Contributor Author

@pvillard31 , please check it.

@pvillard31
Copy link
Contributor

As you can see below, there are still conflicts with the current main branch:

This branch has conflicts that must be resolved

If you feel more comfortable, you may want to close this PR and create a new one.

@avseq1234
Copy link
Contributor Author

you can see below, there are still conflicts with the current main bran

Sorry, I didn't notice it. I will close this PR and create another one this week.

@avseq1234 avseq1234 closed this Sep 18, 2021
@avseq1234 avseq1234 deleted the NIFI-4542 branch September 18, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants