NIFI-6568 - Surface time-to-back-pressure and initial predictions in the UI#3660
Closed
rfellows wants to merge 25 commits intoapache:analytics-frameworkfrom
Closed
NIFI-6568 - Surface time-to-back-pressure and initial predictions in the UI#3660rfellows wants to merge 25 commits intoapache:analytics-frameworkfrom
rfellows wants to merge 25 commits intoapache:analytics-frameworkfrom
Conversation
Contributor
|
lgtm |
Contributor
Contributor
|
@rfellows is it ok to merge this PR? |
Contributor
Author
|
@mcgilman or @scottyaslan would you mind having a look at this PR? |
(cherry picked from commit 050e0fc) (cherry picked from commit 9fd365f)
… just use ConnectionStatusAnalytics directly
…aces as we can just use ConnectionStatusAnalytics directly" This reverts commit 5b9fead.
* DFA-9 - Initial refactor for Status Analytics - created additional interfaces for models, refactored callers to use StatusAnalytics objects with connection context. Implemented SimpleRegression model. DFA-9 - added logging * DFA-9 - relocated query window to CSA from model, adding the prediction percentages and time interval * DFA-9 - checkstyle fixes
(cherry picked from commit e60015d)
…lso changes to properly reflect when predictions can be made vs not. (cherry picked from commit 6fae058)
(cherry picked from commit 6d7a13b)
…d variable names (cherry picked from commit 58c7c81)
(cherry picked from commit b6e35ac)
… use non caching engine for testing
Updates to support multiple variables for features, clearing cached regression model based on r-squared values Added ordinary least squares model, which truly uses multivariable regression. Refactor of interfaces to include more general interface for variate models (that include scoring support). Ratcheck fixes Added test for SimpleRegression. Minor fix for OLS model fixed test errors fixed checkstyle errors (cherry picked from commit fab411b)
… connection status analytics (apache#11)
… object. Also allow configurable model from nifi.properties NIFI-6566 - changes to allow scoring configurations for model in nifi.properties NIFI-6566 - added default implementation value to NiFiProperties NIFI-6566 - correction to default variable name in NiFiProperties, removed unnecessary init method from ConnectionStatusAnalytics Signed-off-by: Matthew Burgess <mattyb149@apache.org> This closes apache#3663
…ns. Added check in ConnectionStatusAnalytics to confirm expected model by type
asfgit
force-pushed
the
analytics-framework
branch
from
e9986c2 to
dbbd41b
Compare
…the UI * Add multi-line tooltips with detail for connection queue back pressure graphics. * Add estimated time to back pressure to connections summary table. * Add back pressure prediction ticks. * add moment.js to format predicted time to back pressure * tweak summary table headings to match data displayed. re-order connection summary columns
rfellows
force-pushed
the
NIFI-6568-predictiveBackPressureUI
branch
from
b743c4e to
4161e64
Compare
Contributor
|
I'm happy to try to review the front end changes here... |
…the connection summary table. Also added a js doc comment.
Contributor
Author
|
@mcgilman I have updated the PR with the minor changes as discussed. |
Contributor
|
@rfellows Thanks! I am a +1 on the front end changes introduced here. I did not review the other commits. |
mcgilman
approved these changes
Aug 28, 2019
asfgit
force-pushed
the
analytics-framework
branch
from
daad09c to
9e35e4c
Compare
Contributor
|
Merged. Pls close this ticket as commit hook does not work with feature branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
master)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.