NIFI-6158 Fix conversion of Avro fixed type with logicalType decimal#3665
Closed
bbende wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-6158 Fix conversion of Avro fixed type with logicalType decimal#3665bbende wants to merge 1 commit intoapache:masterfrom
bbende wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
@bbende Thanks for the fix and detailed explanation about changes. All LGTM, +1. Merging to master. Thank you! |
szaboferee
pushed a commit
to szaboferee/nifi
that referenced
this pull request
Oct 7, 2019
This closes apache#3665. Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
patricker
pushed a commit
to patricker/nifi
that referenced
this pull request
Jan 22, 2020
This closes apache#3665. Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue reported through the Parquet processors, but was really a general problem when reading records with a field that used the "fixed" type and a logicalType of decimal. Our type util code was missing the check for the logicalType and just converting to byte array.
I added a unit test to FetchParquet to prove that it is resolved, although there are no code changes to the Parquert bundle itself.
Also noticed that unit tests were failing to initialize logging correctly due to finding multiple SLF4J bindings, so this PR includes a small change to enforce that logback-core is marked as provided which allows tests to use the slf4j-simple module which is already on the test classpath of all NARs.