NIFI-1788 Fixed listed allowable values

[pvillard31]

• fixed list of allowable values
• replaced related deprecated method when writing

[pvillard31]

Is it expected to use DefaultCodec? I saw we have a property for compression codec, shouldn't we propose something to use this property at this moment?

[olegz]

@pvillard31 I would agree. In any event raising an improvement JIRA will let such discussion to begin.

[pvillard31]

@olegz OK, thanks, I'll raise a JIRA shortly

[olegz]

@pvillard31 I know we have a lot of these "quick-fix-hit-and-run" bugs that require half a line of code change (and you've been absolutely awesome in knocking those out along with more complex JIRAs), but try to always remember that we wouldn't be here if test(s) for these things existed in the first place. So, while fixing such issue I personally strongly encourage to add/modify/create test case as part of the fix.
Feel free to use this:

/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.apache.nifi.processors.hadoop;

import static org.junit.Assert.assertEquals;

import java.util.List;

import org.apache.nifi.components.AllowableValue;
import org.apache.nifi.components.PropertyDescriptor;
import org.junit.Test;

public class CreateHadoopSequenceFileTest {

    @Test
    public void validateAllowableValues() {
        PropertyDescriptor pd = CreateHadoopSequenceFile.COMPRESSION_TYPE;
        List<AllowableValue> allowableValues = pd.getAllowableValues();
        assertEquals("NONE", allowableValues.get(0).getValue());
        assertEquals("RECORD", allowableValues.get(1).getValue());
        assertEquals("BLOCK", allowableValues.get(2).getValue());
    }
}

Cheers!

[pvillard31]

@olegz You are absolutely right! Thanks for the lines of code, added the test in an existing test class for this.