Skip to content

NIFI-6649 - added separate query interval configuration for observati…#3719

Closed
YolandaMDavis wants to merge 3 commits intoapache:masterfrom
YolandaMDavis:NIFI-6649
Closed

NIFI-6649 - added separate query interval configuration for observati…#3719
YolandaMDavis wants to merge 3 commits intoapache:masterfrom
YolandaMDavis:NIFI-6649

Conversation

@YolandaMDavis
Copy link
Copy Markdown
Contributor

…on queries

NIFI-6649 - documentation update

This PR allows users to configure query interval for predictions separately from prediction interval (e.g. predict 1 hour into the future using 3 mins of prior observations).

A new field was added in nifi.properties to support this:

nifi.analytics.query.interval (default is 3 minutes)

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Copy Markdown
Contributor

@mattyb149 mattyb149 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, verified the settings are separate and being used appropriately. Thanks for the improvement! Merging to master

@asfgit asfgit closed this in 8e1452a Sep 12, 2019
szaboferee pushed a commit to szaboferee/nifi that referenced this pull request Oct 7, 2019
…on queries

NIFI-6649 - documentation update

NIFI-6649 - add debug logging for score and prediction information

NIFI-6649 - fix to ensure counts return minimum value of 0 if not infinite or NaN

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes apache#3719
patricker pushed a commit to patricker/nifi that referenced this pull request Jan 22, 2020
…on queries

NIFI-6649 - documentation update

NIFI-6649 - add debug logging for score and prediction information

NIFI-6649 - fix to ensure counts return minimum value of 0 if not infinite or NaN

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes apache#3719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants