NIFI-6649 - added separate query interval configuration for observati…#3719
Closed
YolandaMDavis wants to merge 3 commits intoapache:masterfrom
Closed
NIFI-6649 - added separate query interval configuration for observati…#3719YolandaMDavis wants to merge 3 commits intoapache:masterfrom
YolandaMDavis wants to merge 3 commits intoapache:masterfrom
Conversation
…on queries NIFI-6649 - documentation update
ai-christianson
approved these changes
Sep 10, 2019
mattyb149
approved these changes
Sep 12, 2019
Contributor
mattyb149
left a comment
There was a problem hiding this comment.
+1 LGTM, verified the settings are separate and being used appropriately. Thanks for the improvement! Merging to master
szaboferee
pushed a commit
to szaboferee/nifi
that referenced
this pull request
Oct 7, 2019
…on queries NIFI-6649 - documentation update NIFI-6649 - add debug logging for score and prediction information NIFI-6649 - fix to ensure counts return minimum value of 0 if not infinite or NaN Signed-off-by: Matthew Burgess <mattyb149@apache.org> This closes apache#3719
patricker
pushed a commit
to patricker/nifi
that referenced
this pull request
Jan 22, 2020
…on queries NIFI-6649 - documentation update NIFI-6649 - add debug logging for score and prediction information NIFI-6649 - fix to ensure counts return minimum value of 0 if not infinite or NaN Signed-off-by: Matthew Burgess <mattyb149@apache.org> This closes apache#3719
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on queries
NIFI-6649 - documentation update
This PR allows users to configure query interval for predictions separately from prediction interval (e.g. predict 1 hour into the future using 3 mins of prior observations).
A new field was added in nifi.properties to support this:
nifi.analytics.query.interval (default is 3 minutes)
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
master)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.