NIFI-6662: Adding Kudu Lookup Service#3732
NIFI-6662: Adding Kudu Lookup Service#3732SamHjelmfelt wants to merge 4 commits intoapache:masterfrom
Conversation
granthenke
left a comment
There was a problem hiding this comment.
Thank you for contributing this! I did a quick first pass from a Kudu perspective. Someone with more NiFi knowledge should review too.
...kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
Outdated
Show resolved
Hide resolved
...kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
Show resolved
Hide resolved
...kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
Outdated
Show resolved
Hide resolved
...kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
Outdated
Show resolved
Hide resolved
...kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
Outdated
Show resolved
Hide resolved
...kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
Outdated
Show resolved
Hide resolved
...kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
Show resolved
Hide resolved
...-controller-service/src/test/java/org/apache/nifi/controller/kudu/TestKuduLookupService.java
Outdated
Show resolved
Hide resolved
...-controller-service/src/test/java/org/apache/nifi/controller/kudu/TestKuduLookupService.java
Outdated
Show resolved
Hide resolved
...kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
Outdated
Show resolved
Hide resolved
| <dependency> | ||
| <groupId>org.apache.kudu</groupId> | ||
| <artifactId>kudu-client</artifactId> | ||
| <version>1.10.0</version> |
There was a problem hiding this comment.
Should this version be pulled up to a property in the bundle pom so it can be unified/shared with the processors? All the usages below too.
...kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
Show resolved
Hide resolved
...kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
Show resolved
Hide resolved
...kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
Show resolved
Hide resolved
...kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
Show resolved
Hide resolved
...kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
Outdated
Show resolved
Hide resolved
...-controller-service/src/test/java/org/apache/nifi/controller/kudu/TestKuduLookupService.java
Outdated
Show resolved
Hide resolved
|
@pvillard31 given you reviewed the PutKudu changes from a NiFi perspective, would you be interested in reviewing this one too? |
|
the travis build does not work [ERROR] Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 308.977 s <<< FAILURE! - in org.apache.nifi.controller.kudu.TestKuduLookupService [ERROR] multi_key(org.apache.nifi.controller.kudu.TestKuduLookupService) Time elapsed: 61.457 s <<< ERROR! [ERROR] invalid_key(org.apache.nifi.controller.kudu.TestKuduLookupService) Time elapsed: 61.494 s <<< ERROR! [ERROR] row_not_found(org.apache.nifi.controller.kudu.TestKuduLookupService) Time elapsed: 61.568 s <<< ERROR! [ERROR] single_key(org.apache.nifi.controller.kudu.TestKuduLookupService) Time elapsed: 61.856 s <<< ERROR! So this need to be fixed. Otherwise this looks ready to go to me excluding perhaps that I'm surprised there are no L&N considerations for the lookup nar. But I've not confirmed if this is just part of the kudu nar yet. |
|
The Travis build for Java 8 EN succeeded, but the others failed due to a check-style issue in nifi-shell-authorizer (src/test/java/org/apache/nifi/authorization/ShellUserGroupProviderIT.java). This check-style issue was fixed in NIFI-6400. |
|
👍 LGTM |
NIFI-6662: Cleaning up Kudu logic NIFI-6662: Minor enhancements and build fixes NIFI-6662: This closes apache#3732. Signed-off-by: Joe Witt <joewitt@apache.org>
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Adds lookup service for Apache Kudu
https://issues.apache.org/jira/browse/NIFI-6662
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
[ X ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
[ X ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[ X ] Has your PR been rebased against the latest commit within the target branch (typically
master)?[ X ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.