Skip to content

NIFI-6662: Adding Kudu Lookup Service#3732

Closed
SamHjelmfelt wants to merge 4 commits intoapache:masterfrom
SamHjelmfelt:KuduLookupService
Closed

NIFI-6662: Adding Kudu Lookup Service#3732
SamHjelmfelt wants to merge 4 commits intoapache:masterfrom
SamHjelmfelt:KuduLookupService

Conversation

@SamHjelmfelt
Copy link
Copy Markdown
Contributor

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Adds lookup service for Apache Kudu
https://issues.apache.org/jira/browse/NIFI-6662

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • [ X ] Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • [ X ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • [ X ] Has your PR been rebased against the latest commit within the target branch (typically master)?

  • [ X ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • [ X ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • [ X ] Have you written or updated unit tests to verify your changes?
  • [ X ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • [ X ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Copy Markdown
Member

@granthenke granthenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this! I did a quick first pass from a Kudu perspective. Someone with more NiFi knowledge should review too.

<dependency>
<groupId>org.apache.kudu</groupId>
<artifactId>kudu-client</artifactId>
<version>1.10.0</version>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this version be pulled up to a property in the bundle pom so it can be unified/shared with the processors? All the usages below too.

@granthenke
Copy link
Copy Markdown
Member

@pvillard31 given you reviewed the PutKudu changes from a NiFi perspective, would you be interested in reviewing this one too?

@joewitt
Copy link
Copy Markdown
Contributor

joewitt commented Sep 16, 2019

the travis build does not work

[ERROR] Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 308.977 s <<< FAILURE! - in org.apache.nifi.controller.kudu.TestKuduLookupService
[ERROR] specific_return_columns(org.apache.nifi.controller.kudu.TestKuduLookupService) Time elapsed: 62.203 s <<< ERROR!
java.io.IOException: failed to start masters: Unable to start Master at index 0: /tmp/kudu-binary-jar7895089695673237087/kudu-binary-1.10.0-linux-x86_64/bin/kudu-master: process exited on signal 6 (core dumped)

[ERROR] multi_key(org.apache.nifi.controller.kudu.TestKuduLookupService) Time elapsed: 61.457 s <<< ERROR!
java.io.IOException: failed to start masters: Unable to start Master at index 0: /tmp/kudu-binary-jar1462651242343971495/kudu-binary-1.10.0-linux-x86_64/bin/kudu-master: process exited on signal 6 (core dumped)

[ERROR] invalid_key(org.apache.nifi.controller.kudu.TestKuduLookupService) Time elapsed: 61.494 s <<< ERROR!
java.io.IOException: failed to start masters: Unable to start Master at index 0: /tmp/kudu-binary-jar676288773884896782/kudu-binary-1.10.0-linux-x86_64/bin/kudu-master: process exited on signal 6 (core dumped)

[ERROR] row_not_found(org.apache.nifi.controller.kudu.TestKuduLookupService) Time elapsed: 61.568 s <<< ERROR!
java.io.IOException: failed to start masters: Unable to start Master at index 0: /tmp/kudu-binary-jar7704379724866569711/kudu-binary-1.10.0-linux-x86_64/bin/kudu-master: process exited on signal 6 (core dumped)

[ERROR] single_key(org.apache.nifi.controller.kudu.TestKuduLookupService) Time elapsed: 61.856 s <<< ERROR!
java.io.IOException: failed to start masters: Unable to start Master at index 0: /tmp/kudu-binary-jar2657807676209969593/kudu-binary-1.10.0-linux-x86_64/bin/kudu-master: process exited on signal 6 (core dumped)

So this need to be fixed. Otherwise this looks ready to go to me excluding perhaps that I'm surprised there are no L&N considerations for the lookup nar. But I've not confirmed if this is just part of the kudu nar yet.

@SamHjelmfelt
Copy link
Copy Markdown
Contributor Author

The Travis build for Java 8 EN succeeded, but the others failed due to a check-style issue in nifi-shell-authorizer (src/test/java/org/apache/nifi/authorization/ShellUserGroupProviderIT.java). This check-style issue was fixed in NIFI-6400.

@granthenke
Copy link
Copy Markdown
Member

👍 LGTM

@asfgit asfgit closed this in 2ab9997 Sep 30, 2019
patricker pushed a commit to patricker/nifi that referenced this pull request Jan 22, 2020
NIFI-6662: Cleaning up Kudu logic
NIFI-6662: Minor enhancements and build fixes
NIFI-6662: This closes apache#3732.

Signed-off-by: Joe Witt <joewitt@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants