Skip to content

NIFI-6587 - Fix: Unable save sensitive property value that equals masked value#3778

Closed
rfellows wants to merge 1 commit intoapache:masterfrom
rfellows:NIFI-6587-saveSensitiveParamMatchingMask
Closed

NIFI-6587 - Fix: Unable save sensitive property value that equals masked value#3778
rfellows wants to merge 1 commit intoapache:masterfrom
rfellows:NIFI-6587-saveSensitiveParamMatchingMask

Conversation

@rfellows
Copy link
Copy Markdown
Contributor

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

There was an issue where the Apply button on the Edit Parameter dialog wouldn't be enabled if the parameter value entered matches the masked value that the server sends to the UI (******** - 8 asterisks). This PR fixes that as well as ensures that Set Empty String checkbox is reset on dialog close like the other input fields.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@asfgit asfgit closed this in 2493665 Sep 30, 2019
@scottyaslan
Copy link
Copy Markdown
Contributor

Thanks @rfellows this has been merged to master.

patricker pushed a commit to patricker/nifi that referenced this pull request Jan 22, 2020
…ked value

This closes apache#3778

Signed-off-by: Scott Aslan <scottyaslan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants