NIFI-6703: Add Stateless NiFi to CLI#3795
NIFI-6703: Add Stateless NiFi to CLI#3795SamHjelmfelt wants to merge 8 commits intoapache:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
9e3623d to
0134a46
Compare
|
rebase |
|
Will review... |
… java11 dependency management
|
Thanks for the PR @SamHjelmfelt! And thanks for the subsequent commit. This approach feels better and is inline with our existing approach with NiFi. Two additional comments.
In order for this to work, I had to attach the resulting artifacts in the maven-assembly-plugin configuration of This is arguably a separate concern that we could file a JIRA for addressing in the future.
This file appears to have been removed in this PR. Did you intend to also remove it from the pom? |
|
I've created [1] to address (1) above in a subsequent effort. |
|
@SamHjelmfelt Can you please create follow JIRAs for the following:
|
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-stateless/README.md
Outdated
Show resolved
Hide resolved
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-stateless/README.md
Outdated
Show resolved
Hide resolved
|
I'm a +1 once the subsequent JIRAs are files and the documentation issues mentioned above are resolved. |
|
Created JIRAs as requested by @mcgilman |
|
+1 from me, was able to run the examples using local execution, docker with cat'd json, and docker with file json... will merge shortly |
NIFI-6703: Fixed extracted nar directory and marked api as experimental NIFI-6703: Moving nifi-stateless into nifi-framework NIFI-6703: Refactored to fix jetty/spring issues NIFI-6703: checkstyle fix NIFI-6703: updated to mirror traditional NiFi's bootstrap process and java11 dependency management NIFI-6703: minor changes NIFI-6703: Documentation fixes This closes apache#3795. Signed-off-by: Bryan Bende <bbende@apache.org>
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
https://issues.apache.org/jira/browse/NIFI-6703
Users should be able to easily run Stateless NiFi flows from the CLI without docker.
Added stateless bootstrap and nar to nifi-assembly and removed nifi-stateless/nifi-stateless-assembly. nifi-docker/dockermaven-stateless was updated to accommodate this change.
Added a new top level action (stateless) to nifi.sh which runs the "org.apache.nifi.stateless.NiFiStateless" bootstrap class with the provided arguments after extracting nars. Note that this is intentionally synchronous to allow for many stateless flows on the same machine.
Moved nifi-stateless into nifi-framework to resolve jar conflicts between traditional and stateless runtimes.
Updated stateless-nifi/README.md
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
[ X ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
[ X ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[ X ] Has your PR been rebased against the latest commit within the target branch (typically
master)?[ X ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.