NIFI-6770 - Set validator to Validator.VALID to allow empty password … by thenatog · Pull Request #3823 · apache/nifi

thenatog · 2019-10-17T19:37:03Z

…for truststores.

NIFI-6770 - Added no-password keystore for tests

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
Have you written or updated unit tests to verify your changes?
Have you verified that the full build is successful on both JDK 8 and JDK 11?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

…for truststores. NIFI-6770 - Added no-password keystore for tests

alopresto · 2019-10-18T20:35:37Z

It looks like the code changes here only affect components using a SSLContextService. Did you evaluate if the framework already allows for passwordless truststores for nifi.security.truststore in nifi.properties?

…re. Added a unit test to prove this.

thenatog · 2019-10-28T15:13:34Z

Added another code change and unit test to allow for the NiFi framework to use passwordless truststores. @alopresto

alopresto · 2019-11-06T20:57:21Z

Reviewing...

alopresto · 2019-11-06T21:04:39Z

...le/nifi-ssl-context-service/src/main/java/org/apache/nifi/ssl/StandardSSLContextService.java

            .defaultValue(null)
-            .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+            .addValidator(Validator.VALID)
            .sensitive(true)


Added .required(false).

alopresto · 2019-11-06T23:50:06Z

While doing live PR review with @thenatog we discovered a number of legacy issues with the relevant code & unit tests. We have made additional changes available on this branch: https://github.com/alopresto/nifi/tree/NIFI-6770.

…yStoreUtils. Added utility methods to verify keystore and key passwords. Added unit tests.

…gic. Refactored internal custom validation in StandardSSLContextService. Added and fixed unit tests.

…d keystore passwords. Added unit tests. Resolved failing unit tests.

…ps://nifi.apache.org for live testing. Resolved NPE in SSLContext generation in StandardSSLContextService Added unit tests.

…alhost for InvokeHTTP testing. Resolved TrustManagerFactoryImpl initialization error. Added unit tests.

…lures.

thenatog · 2019-12-11T22:02:03Z

Pulled in the changes Andy made and ran a contrib check. Ran some smoke tests:

Tested insecure NiFi with an InvokeHTTP processor to https://nifi.apache.org/ with a passwordless truststore containing *.apache.org certificate.
a. Removed certificate from passwordless truststore to see PKIX error "unable to find valid certification path to requested target"
Tested secure NiFi with an InvokeHTTP processor to https://nifi.apache.org/ with a passwordless truststore *.apache.org certificate.
a. Removed certificate from passwordless truststore to see PKIX error "unable to find valid certification path to requested target"
Tested secure NiFi with service-level passwordless truststore

…for truststores. Added no-password keystore for tests System NiFi truststore now allows a passwordless truststore. Added a unit test to prove this. Forgot no-password-truststore.jks file for the unit test. Refactored utility method from CertificateUtils to KeyStoreUtils. Added utility methods to verify keystore and key passwords. Added unit tests. Implemented different keystore and truststore validation logic. Refactored internal custom validation in StandardSSLContextService. Added unit test resource for keystore with different key and keystore passwords. Added unit test to generate passwordless truststore for https://nifi.apache.org for live testing. Resolved NPE in SSLContext generation in StandardSSLContextService Added unit test to generate passwordless truststore for localhost for InvokeHTTP testing. Resolved TrustManagerFactoryImpl initialization error. Fixed unit test without proper cleanup which caused RAT failures. Co-authored-by: Andy LoPresto <alopresto@apache.org> This closes apache#3823. Signed-off-by: Andy LoPresto <alopresto@apache.org>

NIFI-6770 - Set validator to Validator.VALID to allow empty password …

87fad62

…for truststores. NIFI-6770 - Added no-password keystore for tests

thenatog added 2 commits October 25, 2019 14:38

NIFI-6770 - System NiFi truststore now allows a passwordless truststo…

dd185bf

…re. Added a unit test to prove this.

NIFI-6770 - Forgot no-password-truststore.jks file for the unit test.

0750d9c

alopresto reviewed Nov 6, 2019

View reviewed changes

alopresto added 7 commits December 11, 2019 12:41

NIFI-6770 [WIP] Refactored utility method from CertificateUtils to Ke…

1358ebc

…yStoreUtils. Added utility methods to verify keystore and key passwords. Added unit tests.

NIFI-6770 Implemented different keystore and truststore validation lo…

576f6fc

…gic. Refactored internal custom validation in StandardSSLContextService. Added and fixed unit tests.

NIFI-6770 Fixed NPE in unit tests.

687963a

NIFI-6770 Added unit test resource for keystore with different key an…

ed0cfbb

…d keystore passwords. Added unit tests. Resolved failing unit tests.

NIFI-6770 Added unit test to generate passwordless truststore for htt…

a7d3518

…ps://nifi.apache.org for live testing. Resolved NPE in SSLContext generation in StandardSSLContextService Added unit tests.

NIFI-6770 Added unit test to generate passwordless truststore for loc…

aa4ab0c

…alhost for InvokeHTTP testing. Resolved TrustManagerFactoryImpl initialization error. Added unit tests.

NIFI-6770 Fixed unit test without proper cleanup which caused RAT fai…

7d41eda

…lures.

asfgit closed this in 4ec9155 Jan 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NIFI-6770 - Set validator to Validator.VALID to allow empty password …#3823

NIFI-6770 - Set validator to Validator.VALID to allow empty password …#3823
thenatog wants to merge 10 commits intoapache:masterfrom
thenatog:NIFI-6770-rebased

thenatog commented Oct 17, 2019

Uh oh!

alopresto commented Oct 18, 2019

Uh oh!

thenatog commented Oct 28, 2019

Uh oh!

alopresto commented Nov 6, 2019

Uh oh!

alopresto Nov 6, 2019

Uh oh!

alopresto commented Nov 6, 2019

Uh oh!

thenatog commented Dec 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

thenatog commented Oct 17, 2019

Description of PR

For all changes:

For code changes:

For documentation related changes:

Note:

Uh oh!

alopresto commented Oct 18, 2019

Uh oh!

thenatog commented Oct 28, 2019

Uh oh!

alopresto commented Nov 6, 2019

Uh oh!

alopresto Nov 6, 2019

Choose a reason for hiding this comment

Uh oh!

alopresto commented Nov 6, 2019

Uh oh!

thenatog commented Dec 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants