Skip to content

NIFI-6853 - flowFileEvent combineCounters hashmap overwritten#3875

Closed
ivan1221 wants to merge 2 commits intoapache:masterfrom
ivan1221:master
Closed

NIFI-6853 - flowFileEvent combineCounters hashmap overwritten#3875
ivan1221 wants to merge 2 commits intoapache:masterfrom
ivan1221:master

Conversation

@ivan1221
Copy link
Contributor

@ivan1221 ivan1221 commented Nov 7, 2019

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@ivan1221
Copy link
Contributor Author

ivan1221 commented Nov 7, 2019

Fix this issue:

https://issues.apache.org/jira/browse/NIFI-6853

@ivan1221
Copy link
Contributor Author

ivan1221 commented Nov 8, 2019

Added unit test to verify behavior of contribution

@asfgit asfgit closed this in 65ba4a2 Dec 13, 2019
@markap14
Copy link
Contributor

Thanks for catching/fixing this @ivan1221! +1 merged to master.

tpalfy pushed a commit to tpalfy/nifi that referenced this pull request Dec 16, 2019
- Added unit test to verify behavior of contribution

This closes apache#3875.

Signed-off-by: Mark Payne <markap14@hotmail.com>
patricker pushed a commit to patricker/nifi that referenced this pull request Jan 22, 2020
- Added unit test to verify behavior of contribution

This closes apache#3875.

Signed-off-by: Mark Payne <markap14@hotmail.com>
natural pushed a commit to natural/nifi that referenced this pull request Feb 1, 2020
- Added unit test to verify behavior of contribution

This closes apache#3875.

Signed-off-by: Mark Payne <markap14@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants