Skip to content

NIFI-6808 Adding KeytabCredentialService to HortonworksSchemaRegistry…#3877

Closed
bbende wants to merge 1 commit intoapache:masterfrom
bbende:NIFI-6808
Closed

NIFI-6808 Adding KeytabCredentialService to HortonworksSchemaRegistry…#3877
bbende wants to merge 1 commit intoapache:masterfrom
bbende:NIFI-6808

Conversation

@bbende
Copy link
Contributor

@bbende bbende commented Nov 8, 2019

… and setting dynamic JAAS config property on client

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

… and setting dynamic JAAS config property on client
@jtstorck jtstorck self-requested a review November 8, 2019 15:59
@jtstorck
Copy link
Contributor

Reviewing...

Copy link
Contributor

@jtstorck jtstorck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @bbende!

Tested this locally with tillt/docker-kdc, Hortonworks Schema Registry 0.8.1, and NiFI 1.11.0-SNAPSHOT.

Verified that a KeytabCredentialsService configured with a principal and keytab can be used with the HortonworksSchemaRegistry controller service. This was tested with a valid principal and worked, and also tested with an invalid principal, which failed as expected.

During the failure while using the invalid principal, I verified in the logs that the referenced schema could not be retrieved, with a root cause of a 401 from the Hortonworks Schema Registry service.

+1, LGTM! Will merge.

@jtstorck jtstorck closed this in 388683a Nov 21, 2019
patricker pushed a commit to patricker/nifi that referenced this pull request Jan 22, 2020
… and setting dynamic JAAS config property on client

This closes apache#3877.
natural pushed a commit to natural/nifi that referenced this pull request Feb 1, 2020
… and setting dynamic JAAS config property on client

This closes apache#3877.
ekovacs pushed a commit to ekovacs/nifi-apache that referenced this pull request Feb 24, 2020
… and setting dynamic JAAS config property on client

This closes apache#3877.

CFM-322: cherry picked apache/nifi master commit 388683a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants