Skip to content

NIFI-6724 - Check for SQS API call result in case of failures#3897

Closed
pvillard31 wants to merge 1 commit intoapache:masterfrom
pvillard31:NIFI-6724
Closed

NIFI-6724 - Check for SQS API call result in case of failures#3897
pvillard31 wants to merge 1 commit intoapache:masterfrom
pvillard31:NIFI-6724

Conversation

@pvillard31
Copy link
Contributor

@pvillard31 pvillard31 commented Nov 20, 2019

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Enables X functionality; fixes bug NIFI-YYYY.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@ep-mo
Copy link

ep-mo commented Nov 22, 2019

I built the NAR for version 1.9.2 (which we are currently running). I have built a similar flow as I did when we discovered the bug. PutSQS from your PR works like a charm. The PutSQS processor in current master would have reported success on both processors (image) because the batch message was OK.
image

Copy link
Contributor

@turcsanyip turcsanyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ep-mo Thanks for your feedback and for the test flow.

The code looks fine. I ran some test flows for both PutSQS and DeleteSQS.
Merging to master.

@pvillard31 Thanks for fixing the issue.

@asfgit asfgit closed this in 6507b78 Nov 22, 2019
patricker pushed a commit to patricker/nifi that referenced this pull request Jan 22, 2020
This closes apache#3897.

Signed-off-by: Peter Turcsanyi <turcsanyi@apache.org>
natural pushed a commit to natural/nifi that referenced this pull request Feb 1, 2020
This closes apache#3897.

Signed-off-by: Peter Turcsanyi <turcsanyi@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants