NIFI-6904 Moving ClassLoader creation before Authorizer instantiation#3903
Closed
bbende wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-6904 Moving ClassLoader creation before Authorizer instantiation#3903bbende wants to merge 1 commit intoapache:masterfrom
bbende wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Will review... |
bahlulh
approved these changes
Nov 25, 2019
Contributor
bahlulh
left a comment
bahlulh
left a comment
There was a problem hiding this comment.
I don't think the logs are needed.
| // start with ClassLoad from authorizer's bundle | ||
| final Bundle authorizerBundle = authorizerBundles.get(0); | ||
| ClassLoader authorizerClassLoader = authorizerBundle.getClassLoader(); | ||
| logger.info("Got Authorizer ClassLoader from bundle"); |
Contributor
There was a problem hiding this comment.
Do we really need these logs?
Contributor
There was a problem hiding this comment.
that log statement should definitely go. Or be changed to debug. Or be updated to provide actual context.
Contributor
There was a problem hiding this comment.
Thanks for your comments. That log statement was removed and the second more meaningful log statement was given more context.
Contributor
|
Thanks @bbende! This has been merged to master. |
patricker
pushed a commit
to patricker/nifi
that referenced
this pull request
Jan 22, 2020
natural
pushed a commit
to natural/nifi
that referenced
this pull request
Feb 1, 2020
ekovacs
pushed a commit
to ekovacs/nifi-apache
that referenced
this pull request
Feb 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
master)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.