Skip to content

NIFI-6944 fixed NiFiClientUtil.getUrl and modified NiFiClientUtilSpec…#3928

Closed
drewkerrigan wants to merge 1 commit intoapache:masterfrom
iss-lab:master
Closed

NIFI-6944 fixed NiFiClientUtil.getUrl and modified NiFiClientUtilSpec…#3928
drewkerrigan wants to merge 1 commit intoapache:masterfrom
iss-lab:master

Conversation

@drewkerrigan
Copy link

@drewkerrigan drewkerrigan commented Dec 12, 2019

… to test non-default WEB_HTTP_PORT

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

fixes bug NIFI-6944.

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?

@drewkerrigan
Copy link
Author

The build failure seems unrelated, although it is interesting that this line failed: https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/index/lucene/TestLuceneEventIndex.java#L234 (assertEquals(5, nodes.size());, nodes.size() was actually 8, not 5). It may suggest another bug in either the test or the lucene event index code.

@asfgit asfgit closed this in 3015ee3 Jan 19, 2020
natural pushed a commit to natural/nifi that referenced this pull request Feb 1, 2020
…dified NiFiClientUtilSpec to test non-default WEB_HTTP_PORT

Signed-off-by: Joe Witt <joewitt@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant