[NIFI-1782] update toolbox, new global menu, and new pallattes#395
Closed
scottyaslan wants to merge 1 commit intoapache:masterfrom
Closed
[NIFI-1782] update toolbox, new global menu, and new pallattes#395scottyaslan wants to merge 1 commit intoapache:masterfrom
scottyaslan wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Hey @scottyaslan this is a great start. I have a couple comments that I think we need to address before we merge this in and then I have additional feedback that I think needs to be included in the next Global Menu/Flow Status PR which will include the remainder of functionality in the mock up in NIFI-1323. For this PR
For the next PR
|
d9b0391 to
6a68edc
Compare
Contributor
Author
|
Thanks @mcgilman! I have made some updates:
|
ae994cb to
b074f2a
Compare
… introduced frontend-maven-plugin to allow bower to manage pulling in 3rd party libs at build time and not shipped with the source
b074f2a to
e367c5f
Compare
Contributor
|
Looks great. The update to the global menu addresses my concerns that I was hoping we could address in the next PR. I've merged this into master. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.