Skip to content

[NIFI-1782] update toolbox, new global menu, and new pallattes#395

Closed
scottyaslan wants to merge 1 commit intoapache:masterfrom
scottyaslan:responsiveDevBranch
Closed

[NIFI-1782] update toolbox, new global menu, and new pallattes#395
scottyaslan wants to merge 1 commit intoapache:masterfrom
scottyaslan:responsiveDevBranch

Conversation

@scottyaslan
Copy link
Contributor

No description provided.

@mcgilman
Copy link
Contributor

mcgilman commented May 1, 2016

Hey @scottyaslan this is a great start. I have a couple comments that I think we need to address before we merge this in and then I have additional feedback that I think needs to be included in the next Global Menu/Flow Status PR which will include the remainder of functionality in the mock up in NIFI-1323.

For this PR

  • The birdseye view does not render the processor or processGroup preview. It appears the position is not being accessed correctly.
  • Can we move flowfont files into a separate directory under font (next to the Roboto directories)? Since flowfont.css came with flowfont can we please co-locate these? We'll also need to identify which images in this bundle were not produced by us and ensure we're updating license/notice accordingly.

For the next PR

  • When dragging a component onto the canvas, the source icon leaves the toolbox when dragged. This icon should remain in the toolbox while a different icon should follow the cursor onto the canvas. Maybe we should update the original icon with something that suggests it's draggable while the dragged icon indicates that a new component is being added. Specifically, I'm thinking of our New Connection icon which shows a Connection arrow with a '+'.
  • The global menu button appears to shift upwards a couple pixels when clicked. I don't think this button should move. Additionally, the button and the menu are too disjoint especially while closing. They transition with different effects and at different rates.
  • The logged in user name wraps onto the following line where the Log Out link would be.

@scottyaslan scottyaslan force-pushed the responsiveDevBranch branch 2 times, most recently from d9b0391 to 6a68edc Compare May 3, 2016 13:41
@scottyaslan
Copy link
Contributor Author

Thanks @mcgilman! I have made some updates:

  • The issue with the birdseye view has been resolve.
  • The flowfont and font-awesome files have been separated. (NOTE: As part of this effort I introduced the frontend-maven-plugin)
  • When dragging a component onto the canvas the source icon now stays in the toolbox.
  • The global menu button no longer shifts upwards.
  • The logged in user name no longer wraps and displays ellipsis if too long.

@scottyaslan scottyaslan force-pushed the responsiveDevBranch branch 3 times, most recently from ae994cb to b074f2a Compare May 3, 2016 17:37
… introduced frontend-maven-plugin to allow bower to manage pulling in 3rd party libs at build time and not shipped with the source
@scottyaslan scottyaslan force-pushed the responsiveDevBranch branch from b074f2a to e367c5f Compare May 3, 2016 17:54
@asfgit asfgit closed this in 1df8fe4 May 3, 2016
@mcgilman
Copy link
Contributor

mcgilman commented May 3, 2016

Looks great. The update to the global menu addresses my concerns that I was hoping we could address in the next PR. I've merged this into master.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants