Skip to content

NIFI-6934: Add support for Postgres flavour of UPSERT action#3951

Closed
sshcherbakov wants to merge 1 commit intoapache:masterfrom
sshcherbakov:NIFI-6934
Closed

NIFI-6934: Add support for Postgres flavour of UPSERT action#3951
sshcherbakov wants to merge 1 commit intoapache:masterfrom
sshcherbakov:NIFI-6934

Conversation

@sshcherbakov
Copy link

@sshcherbakov sshcherbakov commented Dec 20, 2019

Description of PR

Enables Postgres flavour of UPSERT action; fixes bug NIFI-6934.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@MikeThomsen MikeThomsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't have vendor-specific logic like this in a common SQL processor. Consider writing an upsert generator class and throwing UnsupportedOperationException if the type is other than postgres.

@sshcherbakov
Copy link
Author

UPSERT as such is supported not only by Postgres, but unfortunately there is no standard SQL syntax indeed (MySQL syntax is different).
Good idea about making implementation selectable (that's what generator means here I guess) and throwing UnsupportedOperationException.
It should also be possible to auto-detect the target SQL database flavour to select implementation automatically. That's some more work though.
Will try to wrap something up.

@pvillard31
Copy link
Contributor

Implemented with #4350 and #4390.

@pvillard31 pvillard31 closed this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants