Skip to content

NIFI-6968 Create Connection Model Allows Multiple Adds#4009

Closed
nagasivanath wants to merge 0 commit intoapache:masterfrom
nagasivanath:master
Closed

NIFI-6968 Create Connection Model Allows Multiple Adds#4009
nagasivanath wants to merge 0 commit intoapache:masterfrom
nagasivanath:master

Conversation

@nagasivanath
Copy link
Contributor

@nagasivanath nagasivanath commented Jan 22, 2020

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

fixes bug NIFI-6968 Create Connection Model Allows Multiple Adds

Root Cause: In the process of creation of connection, the add / apply button is not disabled , due to which, when the network is slow & when the button is clicked twice unknowingly, the requests are sent multiple times , so multiple connections are created.

Fix: Disable the buttons when the add/update connection is in progress, enable them back after the action.

Impacted Areas: the same issue in case of configuring connections & clicking on Update, also the cancel button should also be disabled when the creation or modification is in process

Tested in : Add Connection, Update connection scenarios using the chrome's network throttling feature making the network very slow

After Fix: the screenshots are taken during the progress, so they are disabled
Update Connection -
update connection after fix

Add Connection -
add connection after fix

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@nagasivanath nagasivanath changed the base branch from master to support/nifi-1.9.x January 22, 2020 19:51
@nagasivanath nagasivanath changed the base branch from support/nifi-1.9.x to master January 22, 2020 19:51
@nagasivanath nagasivanath changed the base branch from master to NIFI-7021-RC3 January 22, 2020 19:56
@nagasivanath nagasivanath changed the base branch from NIFI-7021-RC3 to master January 22, 2020 19:56
@nagasivanath nagasivanath changed the base branch from master to NIFI-7021-RC3 January 23, 2020 04:42
@nagasivanath nagasivanath changed the base branch from NIFI-7021-RC3 to master January 23, 2020 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant