Skip to content

Comments

NIFI-7082 Updated tls-toolkit default server and client certificates …#4046

Merged
alopresto merged 1 commit intoapache:masterfrom
mtien-apache:NIFI-7082
Feb 11, 2020
Merged

NIFI-7082 Updated tls-toolkit default server and client certificates …#4046
alopresto merged 1 commit intoapache:masterfrom
mtien-apache:NIFI-7082

Conversation

@mtien-apache
Copy link
Contributor

…validity days to 825 days.

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

NIFI-7082 Updated tls-toolkit certificate default validity days. Verified server and client certificates show 825 days.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@alopresto
Copy link
Contributor

This fix changes the default certificate validity period to one accepted by macOS 10.15 Catalina.

@alopresto alopresto merged commit 8faea04 into apache:master Feb 11, 2020
asfgit pushed a commit that referenced this pull request Feb 14, 2020
…validity days to 825 days. (#4046)

Signed-off-by: Andy LoPresto <alopresto@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants