Skip to content

NIFI-7419: Passing to ToStringStyle as an parameter to ToStringBuilder#4248

Closed
initdch wants to merge 1 commit intoapache:masterfrom
initdch:NIFI-7419
Closed

NIFI-7419: Passing to ToStringStyle as an parameter to ToStringBuilder#4248
initdch wants to merge 1 commit intoapache:masterfrom
initdch:NIFI-7419

Conversation

@initdch
Copy link

@initdch initdch commented May 1, 2020

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

According to the documentation of ToStringBuilder the method setDefaultStyle() should only be called once since it sets a Singleton value.
Fixed by passing ToStringStyle as an parameter to ToStringBuilder constructor directly.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

…r constructor

Making sure the ToStringBuilder.setDefaultStyle() is not called multiple times by passing to ToStringStyle as an parameter to ToStringBuilder constructor.
@exceptionfactory
Copy link
Contributor

@initdch Thanks for the contribution and documenting the problem in the corresponding Jira issue. Since your original submission, it looks like the PeerStatusCache now includes the same problem. The primary branch is now main, so if you can update the additional class and change the destination branch, this looks good to move forward.

@github-actions
Copy link

We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

@github-actions github-actions bot added the Stale label Jun 13, 2021
@github-actions github-actions bot closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants