NIFI-7419: Passing to ToStringStyle as an parameter to ToStringBuilder#4248
NIFI-7419: Passing to ToStringStyle as an parameter to ToStringBuilder#4248initdch wants to merge 1 commit intoapache:masterfrom
Conversation
…r constructor Making sure the ToStringBuilder.setDefaultStyle() is not called multiple times by passing to ToStringStyle as an parameter to ToStringBuilder constructor.
|
@initdch Thanks for the contribution and documenting the problem in the corresponding Jira issue. Since your original submission, it looks like the |
|
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. |
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
According to the documentation of ToStringBuilder the method setDefaultStyle() should only be called once since it sets a Singleton value.
Fixed by passing ToStringStyle as an parameter to ToStringBuilder constructor directly.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
master)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.