Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-7423 Upgraded jquery dependency version. #4258

Closed
wants to merge 2 commits into from

Conversation

mtien-apache
Copy link
Contributor

@mtien-apache mtien-apache commented May 6, 2020

Thank you for submitting a contribution to Apache NiFi.

Please provide a short description of the PR here:

Description of PR

Upgraded jquery dependency version.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • Have you verified that the full build is successful on both JDK 8 and JDK 11?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@andrewmlim
Copy link
Contributor

andrewmlim commented May 6, 2020

Will help review by performing regression testing on the NiFI UI.

@mtien-apache jQuery 3.5.1 was released two days ago. Would it make sense to upgrade to the latest or was choosing 3.5.0 intentional?

@mtien-apache
Copy link
Contributor Author

mtien-apache commented May 6, 2020

@andrewmlim Yes, I agree 3.5.1 makes sense. I'll upgrade now.

@andrewmlim
Copy link
Contributor

andrewmlim commented May 7, 2020

+1 LGTM. Did not see any regression or unexpected behavior while running through the UI with these changes.

@mtien-apache
Copy link
Contributor Author

mtien-apache commented May 7, 2020

@andrewmlim Thank you

@mcgilman
Copy link
Contributor

mcgilman commented May 7, 2020

Will review...

@asfgit asfgit closed this in 647a9a6 May 8, 2020
@mcgilman
Copy link
Contributor

mcgilman commented May 8, 2020

Thanks for the PR @mtien-apache! Thanks for the review @andrewmlim! This has been merged to master.

phuthientran pushed a commit to FerrelBurn/nifi that referenced this pull request Jan 8, 2021
NIFI-7423 Upgraded jquery dependency version to latest 3.5.1.

This closes apache#4258
driesva pushed a commit to driesva/nifi that referenced this pull request Mar 19, 2021
NIFI-7423 Upgraded jquery dependency version to latest 3.5.1.

This closes apache#4258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants