NIFI-7488 Listening Port property on HandleHttpRequest is not validated when Variable registry is used#4297
NIFI-7488 Listening Port property on HandleHttpRequest is not validated when Variable registry is used#4297adarmiento wants to merge 1 commit into
Conversation
| protected Collection<ValidationResult> customValidate(final ValidationContext validationContext) { | ||
| final List<ValidationResult> results = new ArrayList<>(); | ||
|
|
||
| final Long port = validationContext.getProperty(PORT).evaluateAttributeExpressions().asLong(); |
There was a problem hiding this comment.
Why are you doing this? Is the addValidator call not validating items from the variable registry?
There was a problem hiding this comment.
I made a unit test using invalid values (passing from the registry), calling the .assertValid() was not marking the processor as invalid
There was a problem hiding this comment.
The validators, most of the time, won't do anything if expression language is used to configure the property. I guess we could improve the validators based on the EL scope of the property: if the scope is Variable Registry, we should be able to validate the property even if EL is used.
|
We're marking this PR as stale due to lack of updates in the past few months. If after another couple of weeks the stale label has not been removed this PR will be closed. This stale marker and eventual auto close does not indicate a judgement of the PR just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale tag. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours. |
Description of PR
HandleHttpRequest.PORT is validated
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically
master)?Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not
squashor use--forcewhen pushing to allow for clean monitoring of changes.For code changes:
mvn -Pcontrib-check clean installat the rootnififolder?LICENSEfile, including the mainLICENSEfile undernifi-assembly?NOTICEfile, including the mainNOTICEfile found undernifi-assembly?.displayNamein addition to .name (programmatic access) for each of the new properties?For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.